Make check work for copied datatype IDs to fix nexusformat/code#386#396
Merged
eugenwintersberger merged 2 commits intonexusformat:masterfrom Nov 19, 2015
Merged
Make check work for copied datatype IDs to fix nexusformat/code#386#396eugenwintersberger merged 2 commits intonexusformat:masterfrom
eugenwintersberger merged 2 commits intonexusformat:masterfrom
Conversation
Closed
Contributor
|
Hi Peter, I guess that the array attribute tests for HDF4 and MXML are supposed to fail. Am I right? |
Contributor
Author
|
Maybe: best to ask whomever added the array attribute support. |
Contributor
|
In the test/testsuite.at it is actually expecting the legacy backends to fail with appropriate error messages. |
Contributor
|
Thanks Tobias - this helps. I can mark the tests as "must fail" in which case all tests should pass. |
eugenwintersberger
added a commit
that referenced
this pull request
Nov 19, 2015
Make check work for copied datatype IDs to fix #386
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.